Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Path instead of String in ONNXAdaptiveModel #694

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Use Path instead of String in ONNXAdaptiveModel #694

merged 1 commit into from
Jan 21, 2021

Conversation

skiran252
Copy link
Contributor

load_dir should be a Path variable

@skiran252 skiran252 closed this Jan 21, 2021
@skiran252 skiran252 reopened this Jan 21, 2021
@Timoeller Timoeller self-requested a review January 21, 2021 10:59
Timoeller
Timoeller reviewed Jan 21, 2021
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition.

It currently only affects the ONNXAdaptiveModel. Did you check in our "normal" AdaptiveModel as well? If the changes and tests there become too complex, we can also move forward with just this PR.

@Timoeller Timoeller changed the title Update adaptive_model.py Use Path instead of String in ONNXAdaptiveModel Jan 21, 2021
@Timoeller
Copy link
Contributor

Again thanks for the addition, really appreciate effort coming from external developers. Some feedback for future OSS contributions though:
I changed the title of the PR - it is good practice to make the title more informative.
Next time please also add slightly more description in the PR body, e.g. what caused the error or even link it to an open issue with a bug report.
Thanks

@skiran252
Copy link
Contributor Author

Again thanks for the addition, really appreciate effort coming from external developers. Some feedback for future OSS contributions though:
I changed the title of the PR - it is good practice to make the title more informative.
Next time please also add slightly more description in the PR body, e.g. what caused the error or even link it to an open issue with a bug report.
Thanks

Ya sure. thanks for the suggestion.

@skiran252
Copy link
Contributor Author

Thanks for the addition.

It currently only affects the ONNXAdaptiveModel. Did you check in our "normal" AdaptiveModel as well? If the changes and tests there become too complex, we can also move forward with just this PR.

looks like this just affects ONNXAdaptiveModel and should be a simple change if done on that class.

@Timoeller Timoeller self-requested a review January 21, 2021 17:50
Timoeller
Timoeller approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then lets merge.

@Timoeller Timoeller merged commit 5662734 into deepset-ai:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skiran252 @Timoeller