Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for tools in HuggingFaceAPIChatGenerator #120

Merged
merged 18 commits into from
Oct 22, 2024
Merged

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Oct 16, 2024

Related Issues

Proposed Changes:

I'm adding support for tools in HuggingFaceAPIChatGenerator. Similar to OpenAI PR #57.

How did you test it?

CI, new tests.

Notes for the reviewer

Checklist

@coveralls
Copy link

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11456907558

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 89.515%

Totals Coverage Status
Change from base Build 11436654221: 0.5%
Covered Lines: 1716
Relevant Lines: 1917

💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review October 18, 2024 11:32
@anakin87 anakin87 requested a review from a team as a code owner October 18, 2024 11:32
@anakin87 anakin87 requested review from shadeMe and removed request for a team October 18, 2024 11:32
@anakin87 anakin87 marked this pull request as draft October 21, 2024 15:19
@anakin87 anakin87 marked this pull request as ready for review October 21, 2024 15:36
@anakin87 anakin87 requested a review from shadeMe October 21, 2024 15:36
@anakin87 anakin87 requested a review from shadeMe October 22, 2024 09:06
@anakin87 anakin87 merged commit 77ae056 into main Oct 22, 2024
10 checks passed
@anakin87 anakin87 deleted the hfapi-tools branch October 22, 2024 10:15
@anakin87 anakin87 self-assigned this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants