Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial restructure draft #44
Tutorial restructure draft #44
Changes from 9 commits
de0f921
e6a5693
ac87643
a2c3f36
9d128a3
acad49e
04470d7
d1a0524
b558a66
b99af07
464ba3c
1ea723e
3dd310d
8e4cc8b
080b588
8b8d792
fbf252e
2411b4e
a8bfce2
b939038
f3d24c6
f0f57a4
0daaaa4
babafeb
4a8334b
e3db636
405ed89
dff7aae
fba5806
0ed9fd7
4c711fa
0eb9de3
a7318c5
7e7b4f3
7c437c4
f04a193
627ec52
a52d1bc
2dc469a
11b1d33
f4c77f6
65fa864
1843731
b785f56
10d3329
1296fc8
f0f90c8
5776b81
fc737de
0c7bee8
d31cc90
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment on this section: I really like how this is all clean now and visually it's not crowded anymore. But as they're in the tutorial section on HSH, would it be nicer to have them as drop downs rather than shoot them back to docs for each? I think it can be done with the
.md
cells but would have to try.. But I'd still keep them in docs too, they're useful guides!Happy to be told no on this though. I'm just thinking in terms of flow while you're going through..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, I actually added the dropdown in my comment there by doing that 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be nice. I see that the details tag works in colab. But It doesn't work in jupyter notebook which makes me a bit hesitant to go ahead with this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also add something like: To use it for search, you first need to initialize it. In this tutorial, you'll use ElasticsearchDocumentStore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
3. Wait until the Elasticsearch Server starts.
4. Initialize the ElasticsearchDocumentStore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, maybe it makes sense to just briefly say here what the retriever does. Like one sentence: Retrievers sift through the Documents in the DocumentStore and retrieve the ones that best match the query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I think one sentence of explanation makes sense: A Reader takes the Documents it got from the Retriever and uses them to find the best answer. (or something like that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the code below also have a line for defining the pipe?
pipe = Pipeline()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.