feat: Tweak CacheChecker output type (#6719)

* specify cache checker output type * (de)serialization * tests * add default value for type * reno * mypy * feedback * reduce diff * reduce diff * reno
deepset-ai · Jan 11, 2024 · 60780ce · 60780ce
1 parent 79d67b0
commit 60780ce
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/haystack/components/caching/cache_checker.py b/haystack/components/caching/cache_checker.py
@@ -57,7 +57,7 @@ def from_dict(cls, data: Dict[str, Any]) -> "CacheChecker":
         data["init_parameters"]["document_store"] = docstore
         return default_from_dict(cls, data)
 
-    @component.output_types(hits=List[Document], misses=List[Any])
+    @component.output_types(hits=List[Document], misses=List)
     def run(self, items: List[Any]):
         """
         Checks if any document associated with the specified field is already present in the store. If matching documents

diff --git a/releasenotes/notes/cache_checker_output_type-0b05e75ca41aab61.yaml b/releasenotes/notes/cache_checker_output_type-0b05e75ca41aab61.yaml
@@ -0,0 +1,3 @@
+---
+enhancements:
+  - Modify the output type of `CacheChecker` from `List[Any]` to `List` to make it possible to connect it in a Pipeline.
diff --git a/test/components/caching/test_url_cache_checker.py b/test/components/caching/test_url_cache_checker.py
@@ -6,7 +6,7 @@
 from haystack.components.caching.cache_checker import CacheChecker
 
 
-class TestUrlCacheChecker:
+class TestCacheChecker:
     def test_to_dict(self):
         mocked_docstore_class = document_store_class("MockedDocumentStore")
         component = CacheChecker(document_store=mocked_docstore_class(), cache_field="url")