Allow values that are not dictionaries in the request params in the /search endpoint
#2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krak91
pushed a commit
to Krak91/haystack
that referenced
this pull request
Jul 26, 2022
…/search` endpoint (deepset-ai#2720) * let params contain something else than dictionaries * rewrite the test same style as the main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): fixes #2656
The code processing requests to the
/searchendpoint assumes all the items in theparamsdictionary are also dictionaries, which is wrong. For example, users might want to passdebug: Trueto the endpoint.Proposed changes:
paramsis a dictionary before accessing its keys.Pre-flight checklist