feat: CohereGenerator
#6395
Merged
feat: CohereGenerator
#6395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
2. removed commented files in test-cohere_generators 3. removed unused imports Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
2. remove dict casting of metadata in run Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
2. small change in doc string Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
2. changed api key env var from CO_API_KEY to COHERE_API_KEY Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
2. Added kwargs doc strings for CohereGenerator 3. removed type hints for metadata and replies 4. use COHERE_API_URL instead of hard coded URL. Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
Co-authored-by: Daria Fokina <daria.f93@gmail.com>
Co-authored-by: Daria Fokina <daria.f93@gmail.com>
Co-authored-by: Daria Fokina <daria.f93@gmail.com>
Co-authored-by: Daria Fokina <daria.f93@gmail.com>
Co-authored-by: Daria Fokina <daria.f93@gmail.com>
github-actions
bot
added
topic:tests
topic:CI
2.x
ZanSara
requested review from
dfokina and
julian-risch
and removed request for
a team
julian-risch
requested changes
Nov 23, 2023
Closed
|
Wow, didn't know about this @ZanSara and @julian-risch Great work @sunilkumardash9 Any chance you can add the Chat version, I think they also support it if I'm not mistaken. |
|
@vblagoje in another PR please 🙏 |
|
@vblagoje Yes, I was initially working on the chat endpoint instead of the Generate. I can work on it. |
|
Yes, another PR @ZanSara @sunilkumardash9 chat would be a fantastic contribution. Try to match the format of TGI and OpenAI chat and non-chat generators as much as possible. We would like these to be completely interchangeable. When done, feel free to assign me for chat review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
CohereGenerator#5984Note:
This PR is a workaround to my lack of access to @sunilkumardash9's original PR here: #6034 Please refer to the original PR.