-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example: self-correcting loop for RAG #6420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it looks good...
However, IDK if introducing a custom switch
component is appropriate from the user's perspective...
It is a new concept that makes the example a bit harder to understand and replicate. WDYT?
@masci can you take a look at this PR? We need another opinion on the |
@anakin87 the one in this PR is a bit different use case, but I was thinking that having a similar component in front of a pipeline is the way to go to simplify the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
(just one final comment, but it's good to go)
Related Issues
Proposed Changes:
Adds an example script with the following Pipeline:
The example has 3 custom component:
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.