Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for single meta dict in TextFileToDocument #6606

Merged
merged 7 commits into from
Dec 21, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Dec 20, 2023

Related Issues

Proposed Changes:

Adds support for single metadata dictionary input in TextFileToDocument. In this way, additional metadata can be added to all files processed by this component even when the length of the list of sources is unknown.

How did you test it?

Added tests and run locally.

Notes for the reviewer

See the linked issue and this discussion for context.

Checklist

@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Dec 20, 2023
@ZanSara ZanSara changed the title feat: add support for single meta dict in TextToDocument feat: add support for single meta dict in TextFileToDocument Dec 20, 2023
@ZanSara ZanSara self-assigned this Dec 20, 2023
@ZanSara ZanSara marked this pull request as ready for review December 21, 2023 09:52
@ZanSara ZanSara requested review from a team as code owners December 21, 2023 09:52
@ZanSara ZanSara requested review from dfokina and anakin87 and removed request for a team December 21, 2023 09:52
@ZanSara ZanSara requested a review from anakin87 December 21, 2023 11:04
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚢

@ZanSara ZanSara merged commit cf79aa1 into main Dec 21, 2023
21 checks passed
@ZanSara ZanSara deleted the single-metadata-txt-converter branch December 21, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants