Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support single metadata dictionary in TikaDocumentConverter #6698

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jan 8, 2024

Related Issues

Proposed Changes:

Adds support for single metadata dictionary input in TikaDocumentConverter. In this way, additional metadata can be added to all files processed by this component even when the length of the list of sources is unknown.

How did you test it?

Added tests and run locally.

Notes for the reviewer

See the linked issue and this discussion for context.

Checklist

@github-actions github-actions bot added type:documentation Improvements on the docs topic:tests 2.x Related to Haystack v2.0 labels Jan 8, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 8, 2024

Pull Request Test Coverage Report for Build 7448338237

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 87.365%

Totals Coverage Status
Change from base Build 7446805988: 0.01%
Covered Lines: 4052
Relevant Lines: 4638

💛 - Coveralls

@ZanSara ZanSara marked this pull request as ready for review January 8, 2024 13:27
@ZanSara ZanSara requested review from a team as code owners January 8, 2024 13:27
@ZanSara ZanSara requested review from dfokina and anakin87 and removed request for a team January 8, 2024 13:27
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

I left two small comments about tests...

@ZanSara ZanSara requested a review from anakin87 January 8, 2024 13:48
@ZanSara ZanSara merged commit 974d65f into main Jan 9, 2024
22 checks passed
@ZanSara ZanSara deleted the single-meta-in-tikaconverter branch January 9, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants