feat: Tool dataclass - unified abstraction to represent tools
#8652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
topic:build/distribution
type:documentation
Pull Request Test Coverage Report for Build 12391961949Details
💛 - Coveralls |
anakin87
changed the title
Tool dataclassTool dataclass - unified abstraction to represent tools
anakin87
requested review from
dfokina and
vblagoje
and removed request for
a team
|
@dfokina take a look at this when possible |
vblagoje
reviewed
Dec 18, 2024
| function: Callable | ||
|
|
||
| def __post_init__(self): | ||
| jsonschema_import.check() |
There was a problem hiding this comment.
Knowing that Tool is central piece of the Agents push, should be we make this dependency default? It's 80Kb binary
There was a problem hiding this comment.
I'm not totally sure. Let's involve also @julian-risch in the decision.
- I remember that when we introduce new dependencies, we also have to pay attention to Anaconda.
- We had some issues in the past with
jsonschema: ci: Skip collection oftest_json_schema.pyto fix CI failures #7353
There was a problem hiding this comment.
It seems to be not occurring on 3.9 and after, but ok, let's get this integrated and then we can experiment with including it as a default dependency. Or not.
vblagoje
approved these changes
Dec 18, 2024
dfokina
approved these changes
Dec 18, 2024
davidsbatista
pushed a commit
that referenced
this pull request
Dec 19, 2024
* draft * del HF token in tests * adaptations * progress * fix type * import sorting * more control on deserialization * release note * improvements * support name field * fix chatpromptbuilder test * port Tool from experimental * release note * docs upd * Update tool.py --------- Co-authored-by: Daria Fokina <daria.fokina@deepset.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Tooldataclass from experimental (introduced in feat: Tool class haystack-experimental#53 + feat: convert function into Tool haystack-experimental#114)How did you test it?
CI, several new tests
Notes for the reviewer
DO NOT MERGE
This PR is currently based on the
new-chatmessagebranch, to allow me to create other PRs for Chat Generators, which require both newChatMessageandTool.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.