Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pipeline unit tests #359

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Add pipeline unit tests #359

merged 5 commits into from
Dec 20, 2023

Conversation

mrwyattii
Copy link
Contributor

  • Add destroy() method to pipeline objects
  • Add unit tests for pipeline
  • Fix kwarg parsing bug, where passing a model_config inside a mii_config resulted in an empty model_config

@mrwyattii mrwyattii requested a review from awan-10 as a code owner December 20, 2023 23:02
tohtana
tohtana reviewed Dec 20, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
mrwyattii
mrwyattii commented Dec 20, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@mrwyattii mrwyattii merged commit 165fc1b into main Dec 20, 2023
3 checks passed
@mrwyattii mrwyattii deleted the mrwyattii/pipeline-teardown branch December 20, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tohtana tohtana tohtana approved these changes

@awan-10 awan-10 Awaiting requested review from awan-10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrwyattii @tohtana