Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ds-specific module id to avoid conflicts #6847

Merged
merged 15 commits into from
Jan 31, 2025
Merged

Conversation

tjruwase
Copy link
Contributor

Fix #6772

@tjruwase tjruwase enabled auto-merge January 29, 2025 17:43
@tjruwase tjruwase added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 31, 2025
@tjruwase tjruwase added this pull request to the merge queue Jan 31, 2025
Merged via the queue into master with commit 029e0a3 Jan 31, 2025
12 checks passed
tjruwase added a commit that referenced this pull request Feb 6, 2025
Fix #6772

---------

Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Signed-off-by: Olatunji Ruwase <olruwase@microsoft.com>
siqi654321 pushed a commit to siqi654321/DeepSpeed that referenced this pull request Feb 7, 2025
Fix deepspeedai#6772

---------

Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Signed-off-by: siqi <siqi@tecorigin.com>
traincheck-team pushed a commit to traincheck-team/DeepSpeed that referenced this pull request Feb 9, 2025
Fix deepspeedai#6772

---------

Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Fix-Suggested] ZeRO Stage 3 Overwrites Module ID Attribute Causing Incorrect Expert Placement on GPUs
3 participants