Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GH org references #6998

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Update GH org references #6998

merged 3 commits into from
Feb 5, 2025

Conversation

tjruwase
Copy link
Contributor

@tjruwase tjruwase commented Feb 4, 2025

No description provided.

@tjruwase tjruwase requested a review from stas00 February 4, 2025 15:49
@tjruwase tjruwase requested a review from loadams as a code owner February 4, 2025 15:49
stas00
stas00 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loadams loadams enabled auto-merge February 4, 2025 20:37
tjruwase and others added 3 commits February 4, 2025 14:11
@tjruwase @loadams
Update GH org references
5b7dd42 
Signed-off-by: Olatunji Ruwase <olruwase@microsoft.com>
Signed-off-by: Logan Adams <loadams@microsoft.com>
@tjruwase @loadams
Fix GH repo ref
82da482 
Signed-off-by: Logan Adams <loadams@microsoft.com>
@fabiendupont @loadams
Allow NVIDIA Blackwell (#6991)
e5763b2 
NVIDIA Blackwell GPU generation has number 10. The SM code and
architecture should be `100`, but the current code generates `1.`,
because it expects a 2 characters string.

This change modifies the logic to consider it as a string that contains
a `.`, hence splits the string and uses the array of strings.

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
Signed-off-by: Logan Adams <loadams@microsoft.com>
@loadams loadams added this pull request to the merge queue Feb 5, 2025
Merged via the queue into master with commit fd40516 Feb 5, 2025
16 checks passed
@stas00
Copy link
Collaborator

stas00 commented Feb 5, 2025 •
edited
Loading

@tjruwase, could you please set in the repo settings to auto-delete branches on merge? Otherwise the repo will grow in size... steps are here: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches

And it might be a good idea to nuke old branches - there are many of those and many are 1 year+ old.
https://github.com/deepspeedai/DeepSpeed/branches/all?page=9

Thank you.

@stas00 stas00 deleted the olruwase/docs branch February 5, 2025 16:02
@stas00
Copy link
Collaborator

stas00 commented Feb 5, 2025

branch auto-delete on merge has been enabled

tjruwase added a commit that referenced this pull request Feb 6, 2025
@tjruwase @fabiendupont
Update GH org references (#6998)
75996f8 
Signed-off-by: Olatunji Ruwase <olruwase@microsoft.com>
Signed-off-by: Logan Adams <loadams@microsoft.com>
Signed-off-by: Fabien Dupont <fdupont@redhat.com>
Co-authored-by: Fabien Dupont <fabiendupont@fabiendupont.fr>
Signed-off-by: Olatunji Ruwase <olruwase@microsoft.com>
fitzjalen pushed a commit to fitzjalen/DeepSpeed that referenced this pull request Feb 6, 2025
@tjruwase @fabiendupont @fitzjalen
Update GH org references (deepspeedai#6998)
3970bf1 
Signed-off-by: Olatunji Ruwase <olruwase@microsoft.com>
Signed-off-by: Logan Adams <loadams@microsoft.com>
Signed-off-by: Fabien Dupont <fdupont@redhat.com>
Co-authored-by: Fabien Dupont <fabiendupont@fabiendupont.fr>
siqi654321 pushed a commit to siqi654321/DeepSpeed that referenced this pull request Feb 7, 2025
@tjruwase @fabiendupont
Update GH org references (deepspeedai#6998)
bd7dd7d 
Signed-off-by: Olatunji Ruwase <olruwase@microsoft.com>
Signed-off-by: Logan Adams <loadams@microsoft.com>
Signed-off-by: Fabien Dupont <fdupont@redhat.com>
Co-authored-by: Fabien Dupont <fabiendupont@fabiendupont.fr>
Signed-off-by: siqi <siqi@tecorigin.com>
loadams pushed a commit that referenced this pull request Feb 7, 2025
@tjruwase @fabiendupont @loadams
Update GH org references (#6998)
4d30eb9 
Signed-off-by: Olatunji Ruwase <olruwase@microsoft.com>
Signed-off-by: Logan Adams <loadams@microsoft.com>
Signed-off-by: Fabien Dupont <fdupont@redhat.com>
Co-authored-by: Fabien Dupont <fabiendupont@fabiendupont.fr>
Signed-off-by: Logan Adams <loadams@microsoft.com>
traincheck-team pushed a commit to traincheck-team/DeepSpeed that referenced this pull request Feb 9, 2025
@tjruwase @fabiendupont @traincheck-team
Update GH org references (deepspeedai#6998)
154d93c 
Signed-off-by: Olatunji Ruwase <olruwase@microsoft.com>
Signed-off-by: Logan Adams <loadams@microsoft.com>
Signed-off-by: Fabien Dupont <fdupont@redhat.com>
Co-authored-by: Fabien Dupont <fabiendupont@fabiendupont.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stas00 stas00 stas00 approved these changes

@loadams loadams loadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjruwase @stas00 @loadams @fabiendupont