Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #103

Merged
merged 2 commits into from
Aug 26, 2022
Merged

chore: update dependencies #103

merged 2 commits into from
Aug 26, 2022

Conversation

squarefactory-bot[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

Signed-off-by: GitHub <noreply@github.com>
Copy link
Collaborator

@Darkness4 Darkness4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ArgoCD is updated to a major version. ArgoCD has deprecated configs parameters. While it does not affect us, the next release should indicate about the breaking change.

@Darkness4 Darkness4 merged commit b99f00a into main Aug 26, 2022
@Darkness4 Darkness4 deleted the chore/update-dependencies branch August 26, 2022 12:27
@Darkness4
Copy link
Collaborator

There is actually a breaking change! The CRD of ArgoCD are now handled by helm. To adopt the new CRD management:

YOUR_ARGOCD_NAMESPACE="argocd"
YOUR_ARGOCD_RELEASENAME="argocd"

for crd in "applications.argoproj.io" "applicationsets.argoproj.io" "argocdextensions.argoproj.io" "appprojects.argoproj.io"; do
  kubectl label --overwrite crd $crd app.kubernetes.io/managed-by=Helm
  kubectl annotate --overwrite crd $crd meta.helm.sh/release-namespace="$YOUR_ARGOCD_NAMESPACE"
  kubectl annotate --overwrite crd $crd meta.helm.sh/release-name="$YOUR_ARGOCD_RELEASENAME"
done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant