Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argocd)!: use helm subchart pattern #57

Merged
merged 5 commits into from
Jul 4, 2022
Merged

feat(argocd)!: use helm subchart pattern #57

merged 5 commits into from
Jul 4, 2022

Conversation

Darkness4
Copy link
Collaborator

Closes #55.

This PR will force the user to not use the values field inside the Argo CD application definition.

@Darkness4
feat(argocd): use helm subchart pattern
6eddc45 
Signed-off-by: Nguyen Marc <nguyen_marc@live.fr>
@Darkness4
docs(argocd): use the subchart approach for helm apps
44d0552 
Signed-off-by: Nguyen Marc <nguyen_marc@live.fr>
@Darkness4
chore: merge remote-tracking branch 'origin/main' into feat/helm-subc…
41a9a05 
…harts

Signed-off-by: Nguyen Marc <nguyen_marc@live.fr>
@Darkness4
docs(argocd): fixed outdated details
91bb37f 
Signed-off-by: Nguyen Marc <nguyen_marc@live.fr>
@Darkness4 Darkness4 added S0 Very impact on the end user: this issue must be addressed immediately. kind/enhancement Indicates new feature requests. area/argocd Related to Argo CD features and apps. breaking-change Indicates that a pull request introduces a breaking change. labels Jul 4, 2022
@Darkness4 Darkness4 self-assigned this Jul 4, 2022
@Darkness4 Darkness4 requested a review from amnesium as a code owner July 4, 2022 16:00
@Darkness4
fix(argocd): subchart must be called explicitly
f05d11f 
Signed-off-by: Nguyen Marc <nguyen_marc@live.fr>
@Darkness4 Darkness4 merged commit 313b43e into main Jul 4, 2022
@Darkness4 Darkness4 deleted the feat/helm-subcharts branch July 4, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amnesium amnesium Awaiting requested review from amnesium amnesium is a code owner

Assignees

@Darkness4 Darkness4

Labels
area/argocd Related to Argo CD features and apps. breaking-change Indicates that a pull request introduces a breaking change. kind/enhancement Indicates new feature requests. S0 Very impact on the end user: this issue must be addressed immediately.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace all the helm applications and use the subchart pattern
1 participant
@Darkness4