fix: send url connection info #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cmwylie19
commented
May 9, 2024
•
cmwylie19
commented
- sends the url on the connect emit event.
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
cmwylie19
requested review from
jeff-mccoy,
btlghrants and
schaeferka
as code owners
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
5 tasks
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
btlghrants
pushed a commit
to defenseunicorns/pepr
that referenced
this pull request
May 13, 2024
## Description
Enhances the log function to capture messages and set the
allowWatchBookmarks to be true by default.
Also updates the resync message, in this case message is redudant
```bash
[10:47:20.788] DEBUG (Resync/97227): Watch event reconnect received. Reconnecting after 1 attempts.
message: "Resync triggered by resyncIntervalSec"
```
## Related Issue
Fixes #790
Fixes #789
<!-- or -->
Depends on
defenseunicorns/kubernetes-fluent-client#244
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)
## Checklist before merging
- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/contributor-guide/#submitting-a-pull-request)
followed
---------
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
|
🎉 This PR is included in version 2.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.