Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude registry1 weekly from release-please #1028

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

justinthelaw
Copy link
Contributor

@justinthelaw justinthelaw commented Sep 11, 2024

Description

This PR removes the Registry1 Weekly from release-please configuration to fix the failing tag workflow.

Release-please configuration does not gracefully handle files that do not have the identifier for updating versions if they are included in the release-please configuration as a target. The release-please identifier for Registry1 Weekly was removed due to the v0.12.2 branch not containing the correct refs and code for running the Registry1 weekly test. The commit hash in the Registry1 weekly currently points to a commit after v0.12.2 so that the Registry1 weekly tests run properly, hence why the release-please identifier was removed from the workflow file. In the future, renovate will automate the Registry1 weekly updates and not release-please.

Checklist before merging

@justinthelaw justinthelaw added the bug Something isn't working label Sep 11, 2024
@justinthelaw justinthelaw self-assigned this Sep 11, 2024
@justinthelaw justinthelaw requested a review from a team as a code owner September 11, 2024 19:01
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit 0e75391
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66e1e914acddcd0008724d9c

@justinthelaw justinthelaw changed the title update release-please-config.json fix: exclude registry1 weekly from release-please Sep 11, 2024
@justinthelaw justinthelaw merged commit 4fe42fb into main Sep 11, 2024
28 of 29 checks passed
@justinthelaw justinthelaw deleted the fix-release-please-configuration branch September 11, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants