bug: remove hardcoded gpu request value #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n deploying w/ gpu
✅ Deploy Preview for leapfrogai-docs canceled.
|
gerred
approved these changes
Apr 12, 2024
justinthelaw
approved these changes
Apr 12, 2024
andrewrisse
pushed a commit
that referenced
this pull request
Apr 17, 2024
…n deploying w/ gpu (#386) Signed-off-by: Andrew Risse <andrewrisse@gmail.com>
andrewrisse
pushed a commit
that referenced
this pull request
Apr 17, 2024
…n deploying w/ gpu (#386) Signed-off-by: Andrew Risse <andrewrisse@gmail.com>
andrewrisse
pushed a commit
that referenced
this pull request
Apr 17, 2024
…n deploying w/ gpu (#386) Signed-off-by: Andrew Risse <andrewrisse@gmail.com>
andrewrisse
pushed a commit
that referenced
this pull request
Apr 17, 2024
…n deploying w/ gpu (#386)
andrewrisse
pushed a commit
that referenced
this pull request
Apr 18, 2024
…n deploying w/ gpu (#386)
andrewrisse
pushed a commit
that referenced
this pull request
Apr 18, 2024
…n deploying w/ gpu (#386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #385
We were overriding the
nvidia.com/gpulimit but not the request. Because we only need the limit to be set this PR removes the request from the values.yaml.