Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use template function to set model PVC names #896

Closed
wants to merge 8 commits into from

Conversation

YrrepNoj
Copy link
Member

@YrrepNoj YrrepNoj commented Aug 9, 2024

This PR updates our PVCs and Deployments to use a helper function to determine the name of the PVC based on the model and revision used in the Zarf Package.

This update buys us the ability to deploy multiple models to the cluster without clashing on the name of the PVC they were trying to use.

  • Adds ZARF_CONFIG environment variable to our Make targets for when we build model Zarf packages.
    • This is necessary because the actions.before lifecycle hook needs certain templates applied so it can download the correct model weights at package-create-time.
    • This gives package creators the ability to choose a different model to bake into their package.

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit ad7f302
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66bfafe6e69fcd0008b82336

@YrrepNoj YrrepNoj marked this pull request as ready for review August 14, 2024 16:07
@YrrepNoj YrrepNoj requested a review from a team as a code owner August 14, 2024 16:07
@YrrepNoj YrrepNoj changed the title wip wip wip: playing around with configs and names chore: Use template function to set model PVC names Aug 14, 2024
@YrrepNoj YrrepNoj marked this pull request as draft August 15, 2024 19:28
@YrrepNoj YrrepNoj marked this pull request as ready for review August 16, 2024 16:30
@YrrepNoj YrrepNoj marked this pull request as draft August 16, 2024 17:21
@YrrepNoj
Copy link
Member Author

YrrepNoj commented Sep 6, 2024

This is stale. Will reopen once I pick this up again.

@YrrepNoj YrrepNoj closed this Sep 6, 2024
@justinthelaw justinthelaw deleted the improve-pvc-naming branch September 25, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants