-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use template function to set model PVC names #896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leapfrogai-docs canceled.
|
YrrepNoj
force-pushed
the
improve-pvc-naming
branch
from
August 14, 2024 15:42
8072805
to
5ae04da
Compare
YrrepNoj
changed the title
wip wip wip: playing around with configs and names
chore: Use template function to set model PVC names
Aug 14, 2024
justinthelaw
requested changes
Aug 14, 2024
YrrepNoj
force-pushed
the
improve-pvc-naming
branch
from
August 16, 2024 17:12
b886552
to
4daa288
Compare
This is stale. Will reopen once I pick this up again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our PVCs and Deployments to use a helper function to determine the name of the PVC based on the model and revision used in the Zarf Package.
This update buys us the ability to deploy multiple models to the cluster without clashing on the name of the PVC they were trying to use.
ZARF_CONFIG
environment variable to our Make targets for when we build model Zarf packages.actions.before
lifecycle hook needs certain templates applied so it can download the correct model weights at package-create-time.