chore!: standardize flavors, bundle dir and ghcr namespace #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinthelaw
added
dependencies
✅ Deploy Preview for leapfrogai-docs canceled.
|
justinthelaw
added
the
blocked 🛑
justinthelaw
added this to the Next (M11) - Conformance | Stability | Documentation milestone
|
Post message to #leapfrogai about this breaking change ahead of time. |
justinthelaw
changed the title
justinthelaw
changed the title
|
Relies on #920 |
justinthelaw
force-pushed
the
703-chorerelease-correct-ghcr-repository-directory
branch
from
a323ab6
to
e9df4e5
Compare
YrrepNoj
previously approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Looks good to me. I did open a pondering question to see if we might want to keep our main-latest-bundles buildable.
I think I am leaning towards keeping main buildable and opening a new PR with the change in namespace when we get closer to releasing and I'm curious what others might think.
justinthelaw
removed
the
blocked 🛑
YrrepNoj
approved these changes
Sep 4, 2024
CollectiveUnicorn
approved these changes
Sep 4, 2024
justinthelaw
deleted the
703-chorerelease-correct-ghcr-repository-directory
branch
barronstone
added a commit
to defenseunicorns/uds-security-hub-v1-archive
that referenced
this pull request
Sep 9, 2024
LeapfrogAI v0.12.0 included a breaking change which updated the directory structure to comply with the Made for UDS standard. Reference: defenseunicorns/leapfrogai#933 This PR updates the paths in leapfrogai_names.txt accordingly. It also removes the `rag` package, which is no longer relevant, and adds the `supabase` package to the list. Signed-off-by: Barron Stone <7518212+barronstone@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OVERVIEW
Moves bundles to UDS Common standard directory and shifts the target GHCR repository sub-directory from
packages/leapfrogaitopackages/uds/leapfrogaias part of the Made For UDS standardMoving forward, our packages will be published at a different sub-directory, so at the next release, all bundles must be updated to reflect these.
Additionally, as packages will be by-default published with a flavor of
upstreamthelatestbundles must point to the correct flavor as published byuds zarf package publish. Zarf publishing will append-${FLAVOR}to the package when it is uploaded to the registry, and the bundle must use the correct ref. Due to this, after 0.12.0 is released and artifacts are published, PR #977 should be merged in to add the UDS bundle manifest pointers necessary to use theupstreamflavor and v0.12.0 in general.BREAKING CHANGES
latestUDS bundles onmainbranch will break when this is merged unless the following is done:-upstreamto all components inlatestbundlespackages/uds/leapfrogailatestbundles ref must be done moving forward until a fix (custom replacement strategy) is implementedCHANGES
bundles/)packages/leapfrogaitopackages/uds/leapfrogaias part of the Made For UDS standard-upstreamas the default bundle ref and increments the ref manually