Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiling External/Remote Validations #367

Closed
mike-winberry opened this issue Apr 15, 2024 · 0 comments · Fixed by #384
Closed

Compiling External/Remote Validations #367

mike-winberry opened this issue Apr 15, 2024 · 0 comments · Fixed by #384
Labels
enhancement New feature or request triage Awaiting triage from the team

Comments

@mike-winberry
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In order to support disconnected environments, the ability to "compile" validations into a component-definition, should be created in order to support the portability of component-definitions that rely on remote/external validations.

Describe the solution you'd like

  • Given a component-definition with links to external validations
  • When running the command lula compile (wip) with a component-definition file
  • Then the validations that exist outside the backmatter are pulled and added to backmatter.resources and the links are updated to point to the backmatter instead of the external validation.

Additional context
@mike-winberry mike-winberry added the enhancement New feature or request label Apr 15, 2024
@github-actions github-actions bot added the triage Awaiting triage from the team label Apr 15, 2024
@mike-winberry mike-winberry mentioned this issue Apr 23, 2024
Merged
5 tasks
@mike-winberry mike-winberry linked a pull request Apr 23, 2024 that will close this issue
feat!: #367 compiling external/remote validations #384
Merged
5 tasks
brandtkeller pushed a commit that referenced this issue Apr 25, 2024
@mike-winberry
feat!: #367 compiling external/remote validations (#384)
8bb42b0 
* refactor(common.go): ValidationFromString now uses `validationData.UnmarshalYaml`

* refactor(validation-store): extracted constants and helpers from validation-store to common as they are used in wider areas

* refactor(validate): replace lula link check with common.IsLulaLink

* feat(common): Validation now has ToResource method

* tests(common): add tests for Validation.ToResource()

* feat(compilation): Added tests and functionality for the validation compilation command TODO: create the actual command

* feat(compile): create compile command

* docs: create compile command documentation

* feat(tools): move the compile command under the tools cmd

* feat(compilation): now updates the timestamp for the component definition

* chore: renamecompile command and all associations to use the compose verbiage
This was referenced May 20, 2024
Merged
Merged
This was referenced Jun 29, 2024
Merged
Merged
This was referenced Jul 12, 2024
Merged
Merged
@github-actions github-actions bot mentioned this issue Jul 26, 2024
Merged
This was referenced Aug 5, 2024
Merged
Merged
@github-actions github-actions bot mentioned this issue Aug 16, 2024
Merged
@github-actions github-actions bot mentioned this issue Aug 31, 2024
Merged
@github-actions github-actions bot mentioned this issue Sep 13, 2024
Merged
@github-actions github-actions bot mentioned this issue Sep 27, 2024
Merged
This was referenced Oct 11, 2024
Merged
Merged
@github-actions github-actions bot mentioned this issue Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage Awaiting triage from the team
Projects
Lula and Friends
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: #367 compiling external/remote validations defenseunicorns/lula
1 participant
@mike-winberry