Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controller runtime #379

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Fix controller runtime #379

merged 4 commits into from
Apr 22, 2024

Conversation

brandtkeller
Copy link
Member

@brandtkeller brandtkeller commented Apr 19, 2024

Description

Error in the latest renovate bump for k8s.io dependencies as seen here

Looked at the current use of controller-runtime and realized we could pull direct use out.

Proceeded to then bump the k8s.io dependencies and test.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@brandtkeller brandtkeller self-assigned this Apr 19, 2024
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for lula-docs canceled.

Name Link
🔨 Latest commit 0164e20
🔍 Latest deploy log https://app.netlify.com/sites/lula-docs/deploys/66266aaa59e1db0008b4f607

@brandtkeller brandtkeller added bug Something isn't working dependencies Pull requests that update a dependency file labels Apr 19, 2024
@brandtkeller brandtkeller marked this pull request as ready for review April 19, 2024 14:28
Copy link
Contributor

@mike-winberry mike-winberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brandtkeller brandtkeller merged commit 7d3aec3 into main Apr 22, 2024
7 checks passed
@brandtkeller brandtkeller deleted the fix_controller-runtime branch April 22, 2024 14:02
This was referenced May 20, 2024
This was referenced Jun 29, 2024
This was referenced Jul 12, 2024
This was referenced Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants