Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev validate with optional resources file input #394

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

meganwolf0
Copy link
Collaborator

Description

Added optional -r or --resources-file with expected input of *.json file. This will pass the resources to the validate function as an option to use those "static" resources vs the runtime "dynamic" ones pulled by the domain function GetResources.

Figured if other options were desired for the "Validate" function, those could be extended in the lulaValidationOptions

Related Issue

Relates to #385

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for lula-docs canceled.

Name Link
🔨 Latest commit fe1172f
🔍 Latest deploy log https://app.netlify.com/sites/lula-docs/deploys/662bb1fc81dfe6000844dbf8

@meganwolf0 meganwolf0 self-assigned this Apr 26, 2024
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a few additional scenarios through using the resources flag with expected results. Will file an issue to get the dev command docs created.

@meganwolf0 meganwolf0 linked an issue Apr 26, 2024 that may be closed by this pull request
@meganwolf0 meganwolf0 marked this pull request as ready for review April 26, 2024 16:19
@meganwolf0 meganwolf0 merged commit f034a97 into main Apr 26, 2024
7 checks passed
@meganwolf0 meganwolf0 deleted the 385-add-input-resources-to-dev-validate branch April 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add input resources.json to dev validate command
2 participants