You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
UDS-Core is using finalizers to control deletion of managed objects.
They were using When(Object).isDeleted(..) but this no longer works because the finalizer simply Updates instead of deletes because it adds a deletionTimestamp to the object metadata.
Definition of done:
unit test
e2e test
works for mutate, validate, watch, reconcile
Describe the solution you'd like
Given someone is using Pepr to write an Operator and the operator uses finalizers
When an update occurs
Then they can use the WithDeletionTimestamp filter to check if they need to "operate" on the object
Describe alternatives you've considered
(optional) A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
## Description
Adds a new filter `.WithDeletionTimestamp` to aid Operator developers as
they use `ownerRefs`. Decide if `.HasDeletionTimestamp` needs to be
done.
Needs:
- [x] e2e test
(defenseunicorns/pepr-excellent-examples#61)
- [x] docs
## Related Issue
Fixes#1018Fixes: #1027
<!-- or -->
Relates to #
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)
## Checklist before merging
- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed
---------
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Co-authored-by: Barrett <81570928+btlghrants@users.noreply.github.com>
## Description
Adds a new filter `.WithDeletionTimestamp` to aid Operator developers as
they use `ownerRefs`. Decide if `.HasDeletionTimestamp` needs to be
done.
Needs:
- [x] e2e test
(defenseunicorns/pepr-excellent-examples#61)
- [x] docs
## Related Issue
Fixes#1018Fixes: #1027
<!-- or -->
Relates to #
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)
## Checklist before merging
- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed
---------
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Co-authored-by: Barrett <81570928+btlghrants@users.noreply.github.com>
Is your feature request related to a problem? Please describe.
UDS-Core is using finalizers to control deletion of managed objects.
They were using
When(Object).isDeleted(..)
but this no longer works because the finalizer simplyUpdates
instead of deletes because it adds adeletionTimestamp
to the object metadata.Definition of done:
Describe the solution you'd like
WithDeletionTimestamp
filter to check if they need to "operate" on the objectDescribe alternatives you've considered
(optional) A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: