-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: withdeletiontimestamp filter #1026
Conversation
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
- Coverage 85.90% 85.65% -0.26%
==========================================
Files 26 26
Lines 1022 1032 +10
Branches 219 222 +3
==========================================
+ Hits 878 884 +6
- Misses 133 137 +4
Partials 11 11
|
false positive, this is tested in other ways and does not drop the overall coverage. |
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a stylistic choice on multiple &&
statements vs. Optional Chaining with?
things look good. I'll still have to get more familiar with our tests
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Co-authored-by: Barrett <81570928+btlghrants@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit -- glad we chatted it through.
CodeCov is false positive, the coverage remains at 85. |
## Description Adds a new filter `.WithDeletionTimestamp` to aid Operator developers as they use `ownerRefs`. Decide if `.HasDeletionTimestamp` needs to be done. Needs: - [x] e2e test (defenseunicorns/pepr-excellent-examples#61) - [x] docs ## Related Issue Fixes #1018 Fixes: #1027 <!-- or --> Relates to # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com> Co-authored-by: Barrett <81570928+btlghrants@users.noreply.github.com>
Description
Adds a new filter
.WithDeletionTimestamp
to aid Operator developers as they useownerRefs
. Decide if.HasDeletionTimestamp
needs to be done.Needs:
Related Issue
Fixes #1018
Fixes: #1027
Relates to #
Type of change
Checklist before merging