feat: withdeletiontimestamp filter #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
cmwylie19
requested review from
jeff-mccoy,
btlghrants and
schaeferka
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
- Coverage 85.90% 85.65% -0.26%
==========================================
Files 26 26
Lines 1022 1032 +10
Branches 219 222 +3
==========================================
+ Hits 878 884 +6
- Misses 133 137 +4
Partials 11 11
|
cmwylie19
changed the title
cmwylie19
changed the title
false positive, this is tested in other ways and does not drop the overall coverage. |
cmwylie19
changed the title
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
cmwylie19
commented
Aug 29, 2024
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
samayer12
reviewed
Aug 29, 2024
samayer12
reviewed
Aug 29, 2024
samayer12
reviewed
Aug 29, 2024
samayer12
reviewed
Aug 29, 2024
samayer12
reviewed
Aug 29, 2024
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
btlghrants
reviewed
Aug 30, 2024
Co-authored-by: Barrett <81570928+btlghrants@users.noreply.github.com>
btlghrants
approved these changes
Aug 30, 2024
|
CodeCov is false positive, the coverage remains at 85. |
btlghrants
added a commit
that referenced
this pull request
Sep 10, 2024
## Description Adds a new filter `.WithDeletionTimestamp` to aid Operator developers as they use `ownerRefs`. Decide if `.HasDeletionTimestamp` needs to be done. Needs: - [x] e2e test (defenseunicorns/pepr-excellent-examples#61) - [x] docs ## Related Issue Fixes #1018 Fixes: #1027 <!-- or --> Relates to # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com> Co-authored-by: Barrett <81570928+btlghrants@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new filter
.WithDeletionTimestampto aid Operator developers as they useownerRefs. Decide if.HasDeletionTimestampneeds to be done.Needs:
Related Issue
Fixes #1018
Fixes: #1027
Relates to #
Type of change
Checklist before merging