Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make watchCfg configurable for KFC from Pepr #765

Closed
cmwylie19 opened this issue Apr 29, 2024 · 0 comments · Fixed by #766
Closed

Make watchCfg configurable for KFC from Pepr #765

cmwylie19 opened this issue Apr 29, 2024 · 0 comments · Fixed by #766
Assignees
@cmwylie19
Labels
enhancement New feature or request

Comments

@cmwylie19
Copy link
Contributor

cmwylie19 commented Apr 29, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Debugging a problem we need more configurability across KFC and Pepr

AC: The changes are clearly documented

Describe the solution you'd like

  • Given we need to configure allowWatchBookMarks and resyncInterval
  • When we build the Pepr module
  • Then it is configurable

Describe alternatives you've considered

(optional) A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.
@cmwylie19 cmwylie19 added the enhancement New feature or request label Apr 29, 2024
@cmwylie19 cmwylie19 changed the title Make allowWatchBookMarks optional and resync interval configurable for KFC from Pepr Make watchCfg configurable for KFC from Pepr Apr 29, 2024
@cmwylie19 cmwylie19 mentioned this issue Apr 29, 2024
Merged
5 tasks
@cmwylie19 cmwylie19 self-assigned this May 1, 2024
btlghrants pushed a commit that referenced this issue May 1, 2024
@cmwylie19
feat: watchcfg is configurable for KFC from Pepr (#766)
f7eceeb 
## Description

Under specific conditions the Kubernetes Watch will stop sending events
to the client even though the connection seems healthy. This issue is
well known. After researching, we found that tuning the resync interval
is the best way to ensure the connection stays healthy.

Note that this issue is very rare and is not likely to occur but if your
environment has a lot of network pressure and constant churn it is a
possibility.

## Related Issue

Fixes #765 
<!-- or -->
Relates to # kubernetes-client/javascript#596

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/contributor-guide/#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Pepr Project Board May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwylie19 cmwylie19

Labels
enhancement New feature or request
Projects
Pepr Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: watchcfg is configurable for KFC from Pepr defenseunicorns/pepr
1 participant
@cmwylie19