-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPIKE: Discovery - Feasibility of Prefixing Pino Logs to use .Alias
if it is defined
#858
Labels
Lula
Needed for Lula integration into UDS Core
Comments
cmwylie19
changed the title
Discovery - Feasibility of Prefixing Pino Logs to use
SPIKE: Discovery - Feasibility of Prefixing Pino Logs to use Jun 10, 2024
.Alias
if it is defined.Alias
if it is defined
7 tasks
7 tasks
This work is going really well and super happy with it. Going to move it to the |
feasible. Kim has proven this. |
cmwylie19
added a commit
that referenced
this issue
Sep 24, 2024
## Description We need to verify that we are able to inject the name of the .Alias into logs of the callback function. If it were possible it would need to be done with the Log object (import it into the mutate/validate/watch processor) ```ts const Log = pino({ transport, timestamp: pinoTimeFunction, }); ``` and import that into the [mutate processor](https://github.com/defenseunicorns/pepr/blob/0ec535efc6547f15fb4a02c35f6c3b8b4e5ecc22/src/lib/mutate-processor.ts#L80) and set set Log.prefix = the bindings alias before executing the callback Checklist - [x] Ensure `npx pepr monitor` is working and soak - [ ] soak and verify with user base that feature is performing as expected ## Related Issue Fixes #858 <!-- or --> Relates to #676 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Co-authored-by: Case Wylie <cmwylie19@defenseunicorns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to verify that we are able to inject the name of the .Alias into logs of the callback function.
If it were possible it would need to be done with the
Log
object (import it into the mutate/validate/watch processor)and import that into the mutate processor and set
set
Log.prefix = the bindings alias
before executing the callbackChecklist
The text was updated successfully, but these errors were encountered: