-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add alias prefixing to pino logs #916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
==========================================
+ Coverage 85.87% 92.97% +7.09%
==========================================
Files 26 27 +1
Lines 1218 1252 +34
Branches 292 285 -7
==========================================
+ Hits 1046 1164 +118
+ Misses 158 86 -72
+ Partials 14 2 -12
|
cmwylie19
reviewed
Aug 14, 2024
cmwylie19
reviewed
Aug 14, 2024
cmwylie19
reviewed
Aug 14, 2024
cmwylie19
reviewed
Aug 14, 2024
cmwylie19
reviewed
Aug 14, 2024
cmwylie19
reviewed
Sep 17, 2024
cmwylie19
reviewed
Sep 24, 2024
cmwylie19
reviewed
Sep 24, 2024
cmwylie19
reviewed
Sep 24, 2024
cmwylie19
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2es look good, comments are addressed. Runs well and passes tests. Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to verify that we are able to inject the name of the .Alias into logs of the callback function.
If it were possible it would need to be done with the Log object (import it into the mutate/validate/watch processor)
and import that into the mutate processor and set
set Log.prefix = the bindings alias before executing the callback
Checklist
npx pepr monitor
is working and soakRelated Issue
Fixes #858
Relates to #676
Type of change
Checklist before merging