Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dead link): fix dead link to actions readme #1014

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

Piotr1215
Copy link
Contributor

Description

Fixing a dead link in the README.md pointing incorrectly to actions section.

Related Issue

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (c857468) to head (380b61d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1014   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files          26       26           
  Lines        1005     1005           
  Branches      212      197   -15     
=======================================
  Hits          861      861           
- Misses        133      142    +9     
+ Partials       11        2    -9     

see 3 files with indirect coverage changes

@Piotr1215 Piotr1215 changed the title fix(dead link): Fix dead link to actions README fix(dead link): fix dead link to actions readme Aug 2, 2024
@cmwylie19
Copy link
Collaborator

Thanks for the PR! This commit looks good for the README.md on the repo but it may break the link on the https://docs.pepr.dev, @btlghrants is looking into if this breaks the docs page and how to remedy if it does.

@cmwylie19 cmwylie19 added this to the v0.34.0 milestone Aug 5, 2024
@btlghrants btlghrants self-assigned this Aug 6, 2024
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, @Piotr1215 ! Sorry for the delay -- had to get myself back up-to-speed on our docs generator in order to be sure this wouldn't break anything.

Looks great. Nice spot on the broken link. 👍

@cmwylie19 cmwylie19 merged commit 33dd7c8 into defenseunicorns:main Aug 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants