-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redact store values from logs #1176
Conversation
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
==========================================
- Coverage 93.98% 85.81% -8.18%
==========================================
Files 28 29 +1
Lines 1281 1431 +150
Branches 303 332 +29
==========================================
+ Hits 1204 1228 +24
- Misses 71 185 +114
- Partials 6 18 +12
|
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the demo / walkthrough this morning -- and (mostly) renaming the env var -- it looks good; should meet needs while still allowing us easy access to values in the e2es.
Just need to roll-in those two places in the test titles where the rename didn't happen & I'll approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n/m -- I was able to commit the suggestions myself after the review completed. Test titles updated & LGTM.
Description
Optionally do not expose store values in logs
End to End Test: defenseunicorns/pepr-excellent-examples#78
Related Issue
Fixes #1173
Relates to #
Type of change
Checklist before merging