Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated types from k8s.ts #1194

Merged
merged 4 commits into from
Sep 30, 2024
Merged

chore: remove deprecated types from k8s.ts #1194

merged 4 commits into from
Sep 30, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

We had a circular dependency which caused us to move some types from src/lib/k8s.ts to src/lib/types.ts. We marked them as deprecated and published the news in the release notes. Now we need to remove the types from src/lib/k8s.ts

End to End Test: N/A

Related Issue

Fixes #1193

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19 cmwylie19 requested a review from a team as a code owner September 30, 2024 17:39
@cmwylie19 cmwylie19 added this to the v0.38.0 milestone Sep 30, 2024
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (99dca2a) to head (5fba084).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
- Coverage   85.78%   85.73%   -0.06%     
==========================================
  Files          29       29              
  Lines        1393     1388       -5     
  Branches      313      303      -10     
==========================================
- Hits         1195     1190       -5     
+ Misses        196      180      -16     
- Partials        2       18      +16     
Files with missing lines Coverage Δ
src/fixtures/loader.ts 100.00% <ø> (ø)
src/lib/k8s.ts 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@samayer12 samayer12 self-requested a review September 30, 2024 20:59
Copy link
Collaborator

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice to see deprecated types get removed

@samayer12 samayer12 enabled auto-merge (squash) September 30, 2024 21:00
@samayer12 samayer12 merged commit 9a30baa into main Sep 30, 2024
42 checks passed
@samayer12 samayer12 deleted the 1193 branch September 30, 2024 21:07
cmwylie19 added a commit that referenced this pull request Oct 2, 2024
cmwylie19 added a commit that referenced this pull request Oct 2, 2024
…8.0 (#1211)

Reverts #1194

We need to do a patch today, PR is necessary before `v0.38.0` but we do
not want to create any potential breaking changes due to deprecations
before
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

remove deprecations from k8s.ts
2 participants