-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor complex implementation of request-processing filters #1333
Open
samayer12
wants to merge
37
commits into
main
Choose a base branch
from
1248-refactor-complexity-warnings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+813
−842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
+ Coverage 85.64% 86.37% +0.73%
==========================================
Files 31 34 +3
Lines 1449 1527 +78
Branches 319 309 -10
==========================================
+ Hits 1241 1319 +78
+ Misses 206 190 -16
- Partials 2 18 +16
|
samayer12
force-pushed
the
1248-refactor-complexity-warnings
branch
from
October 25, 2024 21:19
e0c61c8
to
9385b6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of the effort to reduce complexity in the code. Instead of using ternaries that are chained together, this refactor introduces a FilterChain analagous to what you might see in the Spring Framework to achieve the same outcome, improving readability and maintenance.
Related Issue
Relates to #1248
Type of change
Checklist before merging