Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates for undici watch #1384

Merged
merged 4 commits into from
Nov 6, 2024
Merged

chore: updates for undici watch #1384

merged 4 commits into from
Nov 6, 2024

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Nov 4, 2024

Description

Undici fetch is going to be the default watch mechanism in Pepr v0.39.0. This PR updates the docs, watchConfig, and tests that references http2 and documents the PEPR_USE_LEGACY_WATCH env var.

ON HOLD - defenseunicorns/kubernetes-fluent-client#399 KFC needs this merged and released

Related Issue

Fixes #1383

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19 cmwylie19 requested a review from a team as a code owner November 4, 2024 19:39
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@7020907). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1384   +/-   ##
=======================================
  Coverage        ?   78.32%           
=======================================
  Files           ?       36           
  Lines           ?     1698           
  Branches        ?      379           
=======================================
  Hits            ?     1330           
  Misses          ?      366           
  Partials        ?        2           
Files with missing lines Coverage Δ
src/lib/watch-processor.ts 78.64% <ø> (ø)

Copy link
Contributor

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conducted sync review. Potentially breaking change for end-users that rely on PEPR_HTTP2_WATCH, but we'll cover that in release notes.

@samayer12 samayer12 merged commit 6b6d39f into main Nov 6, 2024
46 checks passed
@samayer12 samayer12 deleted the 1383 branch November 6, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

update watch config to confirm to undici and legacy watch
2 participants