-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add more testing around asset class #1753
Conversation
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1753 +/- ##
==========================================
+ Coverage 81.10% 82.04% +0.94%
==========================================
Files 50 51 +1
Lines 2127 2211 +84
Branches 430 436 +6
==========================================
+ Hits 1725 1814 +89
+ Misses 400 395 -5
Partials 2 2
|
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's room for improvement around how we generate test data, and some of the tests may run the risk of being tied too closely to implementations. However, this is an improvement over previously untested code. Any future refactors of the test suite will have a good starting point 👍
Description
The assets class does not have unit tests. The purpose of this PR is to add coverage to ensure the class is working as expected.
Due to the use of dependency injection we are loosely helper functions with the method and functions on the assets class that rely on members of the assets class. Due to that, the intent of this PR is to ensure those injected functions are being with the correct members of the assets class and to hedge against accidentally change by ensuring certain functions are called a certain number of times.
Related Issue
Fixes #1655
Relates to #
Type of change
Checklist before merging