Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: document sdk helpers #774
chore: document sdk helpers #774
Changes from all commits
220a88f
82c3742
f83e17a
e279e54
7face3b
581e88d
b4ad032
8b97eba
a41abca
e6b216f
3327afe
df008f3
fc7091b
9c30074
e772720
94b0c1c
37fc69e
4fc864e
fb139c6
fdb3acf
796fb2f
2b8991d
ef97646
8c39574
7adfdd8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're missing the backticks to close the typescript block here. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% on the link-anchor syntax -- worth testing, for sure -- but I think something like this might work better cuz it takes a reader directly to the appropriate section of the target page, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% on the wording, but something like this would set reader expectation a bit better cuz it set context on the SDK as being "more generic helpers". Kinda hard to tell what "the Pepr SDK" is / how it would be relevant, otherwise.