Skip to content

Commit

Permalink
remove revive action and add to golanci-lint config
Browse files Browse the repository at this point in the history
  • Loading branch information
TristanHoladay committed May 21, 2024
1 parent acbdc56 commit bfac1f8
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 42 deletions.
9 changes: 0 additions & 9 deletions .github/workflows/scan-lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,3 @@ jobs:
uses: pre-commit/action@f7acafac0271bdd064cdfa1b13f17b4350e565ed #
with:
extra_args: --all-files --verbose # pre-commit run --all-files --verbose

- name: Run Revive Action by pulling pre-built image
uses: docker://morphy/revive-action:v2@sha256:087d4e61077087755711ab7e9fae3cc899b7bb07ff8f6a30c3dfb240b1620ae8
with:
config: revive.toml
# Exclude patterns, separated by semicolons (optional)
exclude: "src/cmd/viper.go;src/config/lang/lang.go"
# Path pattern (default: ./...)
path: "./src/..."
29 changes: 27 additions & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ linters:
- govet
- staticcheck
- nilerr
- revive

linters-settings:
govet:
Expand All @@ -36,6 +37,30 @@ linters-settings:
require-specific: true

unused:
# Mark all local variables as used.
# default: true
local-variables-are-used: false

revive:
rules:
- name: blank-imports
- name: context-as-argument
- name: context-keys-type
- name: dot-imports
- name: error-return
- name: error-strings
- name: error-naming
- name: exported
- name: if-return
- name: increment-decrement
- name: var-declaration
- name: package-comments
- name: range
- name: receiver-naming
- name: time-naming
- name: unexported-return
- name: indent-error-flow
- name: errorf
- name: empty-block
- name: superfluous-else
- name: unused-parameter
- name: unreachable-code
- name: redefines-builtin-id
31 changes: 0 additions & 31 deletions revive.toml

This file was deleted.

0 comments on commit bfac1f8

Please sign in to comment.