Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shell completion to brew installs #382

Closed
wants to merge 1 commit into from
Closed

Conversation

corang
Copy link
Contributor

@corang corang commented Feb 1, 2024

Description

Adds steps to release/brew tap to automatically add completion to applicable shells

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@corang corang changed the title Add shell completion to brew installs feat: Add shell completion to brew installs Feb 1, 2024
@corang corang changed the title feat: Add shell completion to brew installs feat: add shell completion to brew installs Feb 1, 2024
@UncleGedd
Copy link
Collaborator

Chatted with several folks about this feature, let's do it. But as @Noxsios pointed out, let's refactor to use this pattern

@UncleGedd
Copy link
Collaborator

closing as this PR as it's pretty old, feel free to refactor as described in the comment above in a separate PR

@UncleGedd UncleGedd closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants