Skip to content

Commit

Permalink
chore!: remove emulated gitlab endpoints from keycloak (#483)
Browse files Browse the repository at this point in the history
## Description

This removes the additional virtualservices we create for "emulating"
gitlab endpoints with keycloak. The initial reason these were added was
to support Mattermost's SSO setup, but SWF has been able to use the
keycloak endpoints directly.

Note that this is a breaking change technically but there are no known
downstream consumers of these virtualservices.

## Related Issue

N/A

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
  • Loading branch information
mjnagel committed Jun 14, 2024
1 parent c6f0137 commit 495960c
Showing 1 changed file with 0 additions and 42 deletions.
42 changes: 0 additions & 42 deletions src/keycloak/chart/templates/uds-package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,45 +119,3 @@ spec:
- istio-mtls-client-certificate
add:
istio-mtls-client-certificate: "%DOWNSTREAM_PEER_CERT%"

- description: "emulate gitlab authorize endpoint"
service: keycloak-http
selector:
app.kubernetes.io/name: keycloak
host: sso
port: 8080
advancedHTTP:
match:
- name: gitlab-authorize
uri:
prefix: /oauth/authorize
rewrite:
uri: "/realms/{{ .Values.realm }}/protocol/openid-connect/auth"

- description: "emulate gitlab user endpoint"
service: keycloak-http
selector:
app.kubernetes.io/name: keycloak
host: sso
port: 8080
advancedHTTP:
match:
- name: gitlab-user
uri:
prefix: /api/v4/user
rewrite:
uri: "/realms/{{ .Values.realm }}/protocol/openid-connect/userinfo"

- description: "emulate gitlab token endpoint"
service: keycloak-http
selector:
app.kubernetes.io/name: keycloak
host: sso
port: 8080
advancedHTTP:
match:
- name: gitlab-token
uri:
prefix: /oauth/token
rewrite:
uri: "/realms/{{ .Values.realm }}/protocol/openid-connect/token"

0 comments on commit 495960c

Please sign in to comment.