-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: kubeapi netpol generation now also includes the ip from the kubernetes service #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnetes service. Fixes a bug in EKS vpc-cni for gitlab where the gitlab pods couldn't talk to the api server
corang
changed the title
fix: kubeapi netpol generation now also includes the ip from the kubernetes service.
fix: kubeapi netpol generation now also includes the ip from the kubernetes service
Mar 4, 2024
TristanHoladay
approved these changes
Mar 4, 2024
mjnagel
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a reasonable change to unblock the issue in EKS - shouldn't be any change to the security posture since we were allowing this traffic already (albeit using the endpoints vs clusterip).
mjnagel
pushed a commit
that referenced
this pull request
Mar 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.14.2](v0.14.1...v0.14.2) (2024-03-04) ### Bug Fixes * basic validations for packages ([#208](#208)) ([9eba3af](9eba3af)) * keycloak volume permissions, UI update ([#223](#223)) ([4454d3e](4454d3e)) * kubeapi netpol generation now also includes the ip from the kubernetes service ([#219](#219)) ([0a83d02](0a83d02)) ### Miscellaneous * **deps:** update uds to v0.9.2 ([#200](#200)) ([e4b54fe](e4b54fe)) * **deps:** update uds-k3d to v0.5.0 ([#186](#186)) ([164bf5f](164bf5f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny
pushed a commit
to owen-grady/uds-core-slim-dev
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.14.2](defenseunicorns/uds-core@v0.14.1...v0.14.2) (2024-03-04) ### Bug Fixes * basic validations for packages ([#208](defenseunicorns/uds-core#208)) ([9eba3af](defenseunicorns/uds-core@9eba3af)) * keycloak volume permissions, UI update ([#223](defenseunicorns/uds-core#223)) ([4454d3e](defenseunicorns/uds-core@4454d3e)) * kubeapi netpol generation now also includes the ip from the kubernetes service ([#219](defenseunicorns/uds-core#219)) ([0a83d02](defenseunicorns/uds-core@0a83d02)) ### Miscellaneous * **deps:** update uds to v0.9.2 ([#200](defenseunicorns/uds-core#200)) ([e4b54fe](defenseunicorns/uds-core@e4b54fe)) * **deps:** update uds-k3d to v0.5.0 ([#186](defenseunicorns/uds-core#186)) ([164bf5f](defenseunicorns/uds-core@164bf5f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
…rnetes service (#219) Fixes a bug in EKS vpc-cni for gitlab where the gitlab pods couldn't talk to the api server ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com> Co-authored-by: Tristan Holaday <40547442+TristanHoladay@users.noreply.github.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.14.2](v0.14.1...v0.14.2) (2024-03-04) ### Bug Fixes * basic validations for packages ([#208](#208)) ([9eba3af](9eba3af)) * keycloak volume permissions, UI update ([#223](#223)) ([4454d3e](4454d3e)) * kubeapi netpol generation now also includes the ip from the kubernetes service ([#219](#219)) ([0a83d02](0a83d02)) ### Miscellaneous * **deps:** update uds to v0.9.2 ([#200](#200)) ([e4b54fe](e4b54fe)) * **deps:** update uds-k3d to v0.5.0 ([#186](#186)) ([164bf5f](164bf5f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in EKS vpc-cni for gitlab where the gitlab pods couldn't talk to the api server
Type of change
Checklist before merging