Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: basic validations for packages #208

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Conversation

UnicornChance
Copy link
Contributor

Description

Improve / Add validations for package deployments and testing.

Keycloak validations are captured on this branch / this PR.

Related Issue

Fixes # 109

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@UnicornChance UnicornChance requested a review from a team February 28, 2024 19:32
@UnicornChance UnicornChance self-assigned this Feb 28, 2024
@UnicornChance UnicornChance linked an issue Feb 28, 2024 that may be closed by this pull request
@UnicornChance UnicornChance reopened this Feb 28, 2024
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As discussed we'll want to get those UI checks added back once we figure out a good way to handle conditional validations - #211

@mjnagel mjnagel merged commit 9eba3af into main Mar 4, 2024
21 checks passed
@mjnagel mjnagel deleted the basic-validations-for-packages branch March 4, 2024 21:35
mjnagel pushed a commit that referenced this pull request Mar 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.14.2](v0.14.1...v0.14.2)
(2024-03-04)


### Bug Fixes

* basic validations for packages
([#208](#208))
([9eba3af](9eba3af))
* keycloak volume permissions, UI update
([#223](#223))
([4454d3e](4454d3e))
* kubeapi netpol generation now also includes the ip from the kubernetes
service ([#219](#219))
([0a83d02](0a83d02))


### Miscellaneous

* **deps:** update uds to v0.9.2
([#200](#200))
([e4b54fe](e4b54fe))
* **deps:** update uds-k3d to v0.5.0
([#186](#186))
([164bf5f](164bf5f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny pushed a commit to owen-grady/uds-core-slim-dev that referenced this pull request Jun 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.14.2](defenseunicorns/uds-core@v0.14.1...v0.14.2)
(2024-03-04)


### Bug Fixes

* basic validations for packages
([#208](defenseunicorns/uds-core#208))
([9eba3af](defenseunicorns/uds-core@9eba3af))
* keycloak volume permissions, UI update
([#223](defenseunicorns/uds-core#223))
([4454d3e](defenseunicorns/uds-core@4454d3e))
* kubeapi netpol generation now also includes the ip from the kubernetes
service ([#219](defenseunicorns/uds-core#219))
([0a83d02](defenseunicorns/uds-core@0a83d02))


### Miscellaneous

* **deps:** update uds to v0.9.2
([#200](defenseunicorns/uds-core#200))
([e4b54fe](defenseunicorns/uds-core@e4b54fe))
* **deps:** update uds-k3d to v0.5.0
([#186](defenseunicorns/uds-core#186))
([164bf5f](defenseunicorns/uds-core@164bf5f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rjferguson21 pushed a commit that referenced this pull request Jul 11, 2024
## Description
Improve / Add validations for package deployments and testing.

Keycloak validations are captured on this
[branch](https://github.com/defenseunicorns/uds-core/tree/authservice-pepr)
/ this [PR](#201).


## Related Issue
Fixes # [109](#109)

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
rjferguson21 pushed a commit that referenced this pull request Jul 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.14.2](v0.14.1...v0.14.2)
(2024-03-04)


### Bug Fixes

* basic validations for packages
([#208](#208))
([9eba3af](9eba3af))
* keycloak volume permissions, UI update
([#223](#223))
([4454d3e](4454d3e))
* kubeapi netpol generation now also includes the ip from the kubernetes
service ([#219](#219))
([0a83d02](0a83d02))


### Miscellaneous

* **deps:** update uds to v0.9.2
([#200](#200))
([e4b54fe](e4b54fe))
* **deps:** update uds-k3d to v0.5.0
([#186](#186))
([164bf5f](164bf5f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic validations for all src packages
2 participants