Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neuvector in unicorn flavor to cgr images #568

Closed
mjnagel opened this issue Jul 12, 2024 · 0 comments · Fixed by #675
Closed

Update neuvector in unicorn flavor to cgr images #568

mjnagel opened this issue Jul 12, 2024 · 0 comments · Fixed by #675
Assignees
Milestone

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Jul 12, 2024

Describe what should be investigated or refactored

#507 provides the initial implementation of the unicorn flavor for uds-core. An outstanding issue prevented switching to the cgr images for neuvector. Once that issue is resolved the source images for the unicorn flavor should be updated.

Links to any relevant code

https://github.com/defenseunicorns/uds-core/blob/main/src/neuvector/zarf.yaml

Additional context

Cgr is tracking our issue with the image and will reach out once the image is fixed.

mjnagel added a commit that referenced this issue Jul 12, 2024
## Description

Adds the unicorn flavor (Chainguard images currently) to uds-core with
CI testing/publishing.

Validated the publish workflow changes on a fork. Note that create was
skipped due to lack of credentials on the fork so the workflow is
running a "dry-run" publish. Take particular note of the `Determine
destination repository` job and the dry run publish commands:
- Snapshot: https://github.com/BagelLab/uds-core/actions/runs/9910149555
- Normal Release:
https://github.com/BagelLab/uds-core/actions/runs/9910127730

Note: An issue has been opened to switch NeuVector from upstream ->
chainguard (#568).
Upstream was chosen instead of registry1 to ensure arm64 support for the
full unicorn flavor.

## Related Issue

N/A

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed

---------

Co-authored-by: Noah Birrer <noah@defenseunicorns.com>
@mjnagel mjnagel self-assigned this Aug 15, 2024
@mjnagel mjnagel removed the blocked label Aug 15, 2024
@mjnagel mjnagel added this to the 0.26.0 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant