-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Velero Azure Blob Support #643
Comments
I think we can definitely evaluate adding direct support similar to what was done in #424. @rwh85 would you be able to clarify the specific ask here? I'm not overly familiar with Azure/Velero but I suspect there's two pieces:
|
@mjnagel We are using bundle overrides for Azure specific values, and this seems like it will work. Other things that need evaluated:
Once the image is baked into the flavors and the init container is added I think this will work. I'll no more as soon as I can test in the next day or so. I'm happy to attempt a PR for this if it's that straight forward, however i didn't want to just assume this would be support and also wanted to make sure the way I see it being integrated was inline with that of the UDS Core team. |
Awesome yeah - for the init container I think you could also add it via bundle overrides although that's probably not a great experience. I don't see any real issue adding it to the baseline, I think you can add multiple plugins without issue but not 💯% sure. Keep us posted, but I think a PR to core would be great, definitely want to avoid you needing to fork (worth noting that you could also load the image separately in a mini zarf package with just that image as well). |
Cool thanks!I haven't seen the mini zarf package concept anywhere yet, but I'll dig into that. The more I think about this change I think it can be as simple as adding the image to the flavors for the plugin and configuring the init container. I'll test it all out and see what works and get a PR in. |
## Description This PR aim to add minimal support for Azure AKS cluster. Changes include: - Add Azure Blob support to velero - [ ] https://support.chainguard.dev/hc/en-us/requests/1077 for the chainguard Azure Plugin Image - Configure neuvector to use ContainerD ## Related Issue Relates to # #643 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed --------- Co-authored-by: Ed <1834551+lemonprogis@users.noreply.github.com> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Is your feature request related to a problem? Please describe.
When deploying UDS Core on Azure AKS it would be nice to have Velero support Azure Blob storage
Describe the solution you'd like
The text was updated successfully, but these errors were encountered: