Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velero Azure Blob Support #643

Closed
rwh85 opened this issue Aug 5, 2024 · 4 comments · Fixed by #644
Closed

Velero Azure Blob Support #643

rwh85 opened this issue Aug 5, 2024 · 4 comments · Fixed by #644
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rwh85
Copy link
Contributor

rwh85 commented Aug 5, 2024

Is your feature request related to a problem? Please describe.

When deploying UDS Core on Azure AKS it would be nice to have Velero support Azure Blob storage

Describe the solution you'd like

  • Given UDS Core is deployed on AKS
  • When Velero backups are taken
  • Then They are saved to Azure Blob storage
@rwh85 rwh85 added the enhancement New feature or request label Aug 5, 2024
@rwh85 rwh85 changed the title Velero Azure Bolb Support Velero Azure Blob Support Aug 5, 2024
@mjnagel
Copy link
Contributor

mjnagel commented Aug 5, 2024

I think we can definitely evaluate adding direct support similar to what was done in #424. @rwh85 would you be able to clarify the specific ask here? I'm not overly familiar with Azure/Velero but I suspect there's two pieces:

  • The specific azure plugin - could add this image by default probably, my only worry is not being able to easily test in our CI process
  • Specific azure config - this should be configurable using bundle overrides I'd expect, but we can also evaluate and document what is necessary here

@rwh85
Copy link
Contributor Author

rwh85 commented Aug 5, 2024

@mjnagel We are using bundle overrides for Azure specific values, and this seems like it will work. Other things that need evaluated:

  • Azure image needs to ship with Zarf package
  • Azure init container needs configured

Once the image is baked into the flavors and the init container is added I think this will work. I'll no more as soon as I can test in the next day or so.

I'm happy to attempt a PR for this if it's that straight forward, however i didn't want to just assume this would be support and also wanted to make sure the way I see it being integrated was inline with that of the UDS Core team.

@mjnagel
Copy link
Contributor

mjnagel commented Aug 5, 2024

Awesome yeah - for the init container I think you could also add it via bundle overrides although that's probably not a great experience. I don't see any real issue adding it to the baseline, I think you can add multiple plugins without issue but not 💯% sure. Keep us posted, but I think a PR to core would be great, definitely want to avoid you needing to fork (worth noting that you could also load the image separately in a mini zarf package with just that image as well).

@rwh85
Copy link
Contributor Author

rwh85 commented Aug 6, 2024

Cool thanks!I haven't seen the mini zarf package concept anywhere yet, but I'll dig into that. The more I think about this change I think it can be as simple as adding the image to the flavors for the plugin and configuring the init container. I'll test it all out and see what works and get a PR in.

@rwh85 rwh85 self-assigned this Aug 6, 2024
@rwh85 rwh85 linked a pull request Aug 6, 2024 that will close this issue
6 tasks
mjnagel added a commit that referenced this issue Aug 16, 2024
## Description

This PR aim to add minimal support for Azure AKS cluster. 

Changes include: 

- Add Azure Blob support to velero
- [ ] https://support.chainguard.dev/hc/en-us/requests/1077 for the
chainguard Azure Plugin Image

- Configure neuvector to use ContainerD

## Related Issue

Relates to # #643

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

---------

Co-authored-by: Ed <1834551+lemonprogis@users.noreply.github.com>
Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
@mjnagel mjnagel added this to the 0.26.0 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants