Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce advancedHTTP for expose field & change podLabels to selector #154

Merged
merged 17 commits into from
Feb 9, 2024

Conversation

jeff-mccoy
Copy link
Member

@jeff-mccoy jeff-mccoy commented Feb 7, 2024

This PR deprecates podLabels, 'remotePodsLabels', and match and changes this to selector, remoteSelector and advancedHTTP.match, respectively. This PR also introduces advancedHTTP which brings support for the following VirtualService fields:

  • corsPolicy
  • directResponse
  • headers
  • retries
  • rewrite
  • timeout
  • weight

@jeff-mccoy jeff-mccoy changed the title feat: introduce advacedHTTP for expose field feat: introduce advacedHTTP for expose field & change podLabels to selector Feb 8, 2024
UnicornChance
UnicornChance previously approved these changes Feb 8, 2024
@UnicornChance UnicornChance dismissed their stale review February 8, 2024 17:54

I probably should wait to approve till CI works successfully

@mjnagel mjnagel changed the title feat: introduce advacedHTTP for expose field & change podLabels to selector feat: introduce advancedHTTP for expose field & change podLabels to selector Feb 8, 2024
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor comments, overall good. Probably a good pattern we can set here for deprecating things and removal later on.

src/pepr/config.ts Show resolved Hide resolved
src/pepr/operator/crd/sources/v1alpha1.ts Outdated Show resolved Hide resolved
src/pepr/operator/crd/sources/v1alpha1.ts Outdated Show resolved Hide resolved
src/pepr/operator/crd/sources/v1alpha1.ts Outdated Show resolved Hide resolved
jeff-mccoy and others added 4 commits February 8, 2024 18:07
Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
mjnagel
mjnagel previously approved these changes Feb 9, 2024
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach with the migrate fn. Might need to regen the CRD file(s) after those spelling changes to update the comments? LGTM overall.

@jeff-mccoy jeff-mccoy merged commit 1079267 into main Feb 9, 2024
19 checks passed
@jeff-mccoy jeff-mccoy deleted the uds-operator-advanced-http branch February 9, 2024 05:31
jeff-mccoy pushed a commit that referenced this pull request Feb 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.12.0](v0.11.1...v0.12.0)
(2024-02-09)


### Features

* introduce advancedHTTP for expose field & change podLabels to selector
([#154](#154))
([1079267](1079267))


### Miscellaneous

* **deps:** pin dependencies
([#79](#79))
([bfab11e](bfab11e))
* remove retry-action action on registry1 docker login
([#160](#160))
([eea0c93](eea0c93))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny pushed a commit to owen-grady/uds-core-slim-dev that referenced this pull request Jun 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.12.0](defenseunicorns/uds-core@v0.11.1...v0.12.0)
(2024-02-09)


### Features

* introduce advancedHTTP for expose field & change podLabels to selector
([#154](defenseunicorns/uds-core#154))
([1079267](defenseunicorns/uds-core@1079267))


### Miscellaneous

* **deps:** pin dependencies
([#79](defenseunicorns/uds-core#79))
([bfab11e](defenseunicorns/uds-core@bfab11e))
* remove retry-action action on registry1 docker login
([#160](defenseunicorns/uds-core#160))
([eea0c93](defenseunicorns/uds-core@eea0c93))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants