-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce advancedHTTP for expose field & change podLabels to selector #154
Conversation
I probably should wait to approve till CI works successfully
This reverts commit bf762ee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor comments, overall good. Probably a good pattern we can set here for deprecating things and removal later on.
Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach with the migrate fn. Might need to regen the CRD file(s) after those spelling changes to update the comments? LGTM overall.
🤖 I have created a release *beep* *boop* --- ## [0.12.0](v0.11.1...v0.12.0) (2024-02-09) ### Features * introduce advancedHTTP for expose field & change podLabels to selector ([#154](#154)) ([1079267](1079267)) ### Miscellaneous * **deps:** pin dependencies ([#79](#79)) ([bfab11e](bfab11e)) * remove retry-action action on registry1 docker login ([#160](#160)) ([eea0c93](eea0c93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.12.0](defenseunicorns/uds-core@v0.11.1...v0.12.0) (2024-02-09) ### Features * introduce advancedHTTP for expose field & change podLabels to selector ([#154](defenseunicorns/uds-core#154)) ([1079267](defenseunicorns/uds-core@1079267)) ### Miscellaneous * **deps:** pin dependencies ([#79](defenseunicorns/uds-core#79)) ([bfab11e](defenseunicorns/uds-core@bfab11e)) * remove retry-action action on registry1 docker login ([#160](defenseunicorns/uds-core#160)) ([eea0c93](defenseunicorns/uds-core@eea0c93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR deprecates
podLabels
, 'remotePodsLabels', andmatch
and changes this toselector
,remoteSelector
andadvancedHTTP.match
, respectively. This PR also introducesadvancedHTTP
which brings support for the followingVirtualService
fields:corsPolicy
directResponse
headers
retries
rewrite
timeout
weight