chore: identity flavors #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity test, remove vlaidation breaking single capability test
|
FYSA: This is failing ci because of a zarf bug zarf-dev/zarf#2320, which is impacting main due to a change (change metrics server from |
|
Okay this should be good again. @jeff-mccoy not sure what you want to do with the keycloak specific interface/endpoint checks. Definitely nice to have on the full runs, but without istio they break the single package tests. I left them commented out for now just so ci would pass rather than deleting in case there were specific thoughts on keeping them in some capacity. |
|
Of course the full install failed immediately after i commented on the pepr jest tests, but dont think that is related to anything i implemented here. |
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
## Description Broke out flavored values files Created common keycloak component imported into flavored components Added templating for security context for keycloak image to facilitate using registry1 image Added templating to all helm resources that require istio to enable single capability tests to work Commented out keycloak validate task that checks the exposed endpoints as single capability tests dont have istio and cannot test that functionality Note: if using colima on a mac the local image in keycloak doesnt "just work" as crane requires the default docker sock unix:///var/run/docker.sock or DOCKER_HOST to be set. This behavior is unique to this scenario and colima does not symlink anymore so docker desktop can be colocated on the same machine. This can be resolved by running `export DOCKER_HOST=unix:///Users/<username>/.colima/<colima-profile>/docker.sock` prior to attempting to build the package containing keycloak. Tested on registry1 flavor on ubuntu amd64 and upstream with darwin arm64. ## Related Issue Fixes # <!-- or --> Relates to # ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed --------- Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com> Co-authored-by: Megamind <882485+jeff-mccoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Broke out flavored values files
Created common keycloak component imported into flavored components
Added templating for security context for keycloak image to facilitate using registry1 image
Added templating to all helm resources that require istio to enable single capability tests to work
Commented out keycloak validate task that checks the exposed endpoints as single capability tests dont have istio and cannot test that functionality
Note: if using colima on a mac the local image in keycloak doesnt "just work" as crane requires the default docker sock unix:///var/run/docker.sock or DOCKER_HOST to be set. This behavior is unique to this scenario and colima does not symlink anymore so docker desktop can be colocated on the same machine. This can be resolved by running
export DOCKER_HOST=unix:///Users/<username>/.colima/<colima-profile>/docker.sockprior to attempting to build the package containing keycloak.Tested on registry1 flavor on ubuntu amd64 and upstream with darwin arm64.
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging