fix: unwanted exemption deletions #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mption controller refactors; updated Operator README
mjnagel
reviewed
Mar 27, 2024
5 tasks
mjnagel
approved these changes
Mar 29, 2024
mjnagel
pushed a commit
that referenced
this pull request
Mar 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.18.0](v0.17.0...v0.18.0) (2024-03-29) ### Features * switch loki to simple scalable ([#156](#156)) ([1661b15](1661b15)) ### Bug Fixes * add kubeapi egress for neuvector enforcer ([#291](#291)) ([87fc886](87fc886)) * pepr ironbank renovate update ([#299](#299)) ([287e40d](287e40d)) * unwanted exemption deletions ([#290](#290)) ([50b0cd4](50b0cd4)) ### Miscellaneous * add debug output to release workflow ([#285](#285)) ([5f96865](5f96865)) * **deps:** update dependency defenseunicorns/uds-common to v0.3.6 ([#261](#261)) ([1b5398b](1b5398b)) * **deps:** update githubactions ([#242](#242)) ([1eb2e2c](1eb2e2c)) * **deps:** update pepr to v0.28.6 ([#300](#300)) ([86b43e4](86b43e4)) * **deps:** update prometheus-stack ([#190](#190)) ([f9a605a](f9a605a)) * **deps:** update uds-k3d to v0.6.0 ([#240](#240)) ([6a26523](6a26523)) * **deps:** update velero ([#260](#260)) ([f352008](f352008)) * support headless keycloak admin user ([#307](#307)) ([a0e51b6](a0e51b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mjnagel
pushed a commit
that referenced
this pull request
Mar 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.18.0](v0.17.0...v0.18.0) (2024-03-29) ### Features * switch loki to simple scalable ([#156](#156)) ([1661b15](1661b15)) ### Bug Fixes * add kubeapi egress for neuvector enforcer ([#291](#291)) ([87fc886](87fc886)) * pepr ironbank renovate update ([#299](#299)) ([287e40d](287e40d)) * release workflow k3d image ([#316](#316)) ([e7835e0](e7835e0)) * unwanted exemption deletions ([#290](#290)) ([50b0cd4](50b0cd4)) ### Miscellaneous * add debug output to release workflow ([#285](#285)) ([5f96865](5f96865)) * **deps:** update dependency defenseunicorns/uds-common to v0.3.6 ([#261](#261)) ([1b5398b](1b5398b)) * **deps:** update githubactions ([#242](#242)) ([1eb2e2c](1eb2e2c)) * **deps:** update pepr to v0.28.6 ([#300](#300)) ([86b43e4](86b43e4)) * **deps:** update prometheus-stack ([#190](#190)) ([f9a605a](f9a605a)) * **deps:** update uds-k3d to v0.6.0 ([#240](#240)) ([6a26523](6a26523)) * **deps:** update velero ([#260](#260)) ([f352008](f352008)) * **main:** release 0.18.0 ([#286](#286)) ([40e6b7b](40e6b7b)) * support headless keycloak admin user ([#307](#307)) ([a0e51b6](a0e51b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny
pushed a commit
to owen-grady/uds-core-slim-dev
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.18.0](defenseunicorns/uds-core@v0.17.0...v0.18.0) (2024-03-29) ### Features * switch loki to simple scalable ([#156](defenseunicorns/uds-core#156)) ([1661b15](defenseunicorns/uds-core@1661b15)) ### Bug Fixes * add kubeapi egress for neuvector enforcer ([#291](defenseunicorns/uds-core#291)) ([87fc886](defenseunicorns/uds-core@87fc886)) * pepr ironbank renovate update ([#299](defenseunicorns/uds-core#299)) ([287e40d](defenseunicorns/uds-core@287e40d)) * unwanted exemption deletions ([#290](defenseunicorns/uds-core#290)) ([50b0cd4](defenseunicorns/uds-core@50b0cd4)) ### Miscellaneous * add debug output to release workflow ([#285](defenseunicorns/uds-core#285)) ([5f96865](defenseunicorns/uds-core@5f96865)) * **deps:** update dependency defenseunicorns/uds-common to v0.3.6 ([#261](defenseunicorns/uds-core#261)) ([1b5398b](defenseunicorns/uds-core@1b5398b)) * **deps:** update githubactions ([#242](defenseunicorns/uds-core#242)) ([1eb2e2c](defenseunicorns/uds-core@1eb2e2c)) * **deps:** update pepr to v0.28.6 ([#300](defenseunicorns/uds-core#300)) ([86b43e4](defenseunicorns/uds-core@86b43e4)) * **deps:** update prometheus-stack ([#190](defenseunicorns/uds-core#190)) ([f9a605a](defenseunicorns/uds-core@f9a605a)) * **deps:** update uds-k3d to v0.6.0 ([#240](defenseunicorns/uds-core#240)) ([6a26523](defenseunicorns/uds-core@6a26523)) * **deps:** update velero ([#260](defenseunicorns/uds-core#260)) ([f352008](defenseunicorns/uds-core@f352008)) * support headless keycloak admin user ([#307](defenseunicorns/uds-core#307)) ([a0e51b6](defenseunicorns/uds-core@a0e51b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny
pushed a commit
to owen-grady/uds-core-slim-dev
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.18.0](defenseunicorns/uds-core@v0.17.0...v0.18.0) (2024-03-29) ### Features * switch loki to simple scalable ([#156](defenseunicorns/uds-core#156)) ([1661b15](defenseunicorns/uds-core@1661b15)) ### Bug Fixes * add kubeapi egress for neuvector enforcer ([#291](defenseunicorns/uds-core#291)) ([87fc886](defenseunicorns/uds-core@87fc886)) * pepr ironbank renovate update ([#299](defenseunicorns/uds-core#299)) ([287e40d](defenseunicorns/uds-core@287e40d)) * release workflow k3d image ([#316](defenseunicorns/uds-core#316)) ([e7835e0](defenseunicorns/uds-core@e7835e0)) * unwanted exemption deletions ([#290](defenseunicorns/uds-core#290)) ([50b0cd4](defenseunicorns/uds-core@50b0cd4)) ### Miscellaneous * add debug output to release workflow ([#285](defenseunicorns/uds-core#285)) ([5f96865](defenseunicorns/uds-core@5f96865)) * **deps:** update dependency defenseunicorns/uds-common to v0.3.6 ([#261](defenseunicorns/uds-core#261)) ([1b5398b](defenseunicorns/uds-core@1b5398b)) * **deps:** update githubactions ([#242](defenseunicorns/uds-core#242)) ([1eb2e2c](defenseunicorns/uds-core@1eb2e2c)) * **deps:** update pepr to v0.28.6 ([#300](defenseunicorns/uds-core#300)) ([86b43e4](defenseunicorns/uds-core@86b43e4)) * **deps:** update prometheus-stack ([#190](defenseunicorns/uds-core#190)) ([f9a605a](defenseunicorns/uds-core@f9a605a)) * **deps:** update uds-k3d to v0.6.0 ([#240](defenseunicorns/uds-core#240)) ([6a26523](defenseunicorns/uds-core@6a26523)) * **deps:** update velero ([#260](defenseunicorns/uds-core#260)) ([f352008](defenseunicorns/uds-core@f352008)) * **main:** release 0.18.0 ([#286](defenseunicorns/uds-core#286)) ([40e6b7b](defenseunicorns/uds-core@40e6b7b)) * support headless keycloak admin user ([#307](defenseunicorns/uds-core#307)) ([a0e51b6](defenseunicorns/uds-core@a0e51b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
## Description Fix the cases when matchers are deleted because they're nearly identical but not actually identical. ## Related Issue Fixes #289 ### Additional Context To help in bug fix and refactoring i merged #248 into this PR ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed --------- Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.18.0](v0.17.0...v0.18.0) (2024-03-29) ### Features * switch loki to simple scalable ([#156](#156)) ([1661b15](1661b15)) ### Bug Fixes * add kubeapi egress for neuvector enforcer ([#291](#291)) ([87fc886](87fc886)) * pepr ironbank renovate update ([#299](#299)) ([287e40d](287e40d)) * unwanted exemption deletions ([#290](#290)) ([50b0cd4](50b0cd4)) ### Miscellaneous * add debug output to release workflow ([#285](#285)) ([5f96865](5f96865)) * **deps:** update dependency defenseunicorns/uds-common to v0.3.6 ([#261](#261)) ([1b5398b](1b5398b)) * **deps:** update githubactions ([#242](#242)) ([1eb2e2c](1eb2e2c)) * **deps:** update pepr to v0.28.6 ([#300](#300)) ([86b43e4](86b43e4)) * **deps:** update prometheus-stack ([#190](#190)) ([f9a605a](f9a605a)) * **deps:** update uds-k3d to v0.6.0 ([#240](#240)) ([6a26523](6a26523)) * **deps:** update velero ([#260](#260)) ([f352008](f352008)) * support headless keycloak admin user ([#307](#307)) ([a0e51b6](a0e51b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.18.0](v0.17.0...v0.18.0) (2024-03-29) ### Features * switch loki to simple scalable ([#156](#156)) ([1661b15](1661b15)) ### Bug Fixes * add kubeapi egress for neuvector enforcer ([#291](#291)) ([87fc886](87fc886)) * pepr ironbank renovate update ([#299](#299)) ([287e40d](287e40d)) * release workflow k3d image ([#316](#316)) ([e7835e0](e7835e0)) * unwanted exemption deletions ([#290](#290)) ([50b0cd4](50b0cd4)) ### Miscellaneous * add debug output to release workflow ([#285](#285)) ([5f96865](5f96865)) * **deps:** update dependency defenseunicorns/uds-common to v0.3.6 ([#261](#261)) ([1b5398b](1b5398b)) * **deps:** update githubactions ([#242](#242)) ([1eb2e2c](1eb2e2c)) * **deps:** update pepr to v0.28.6 ([#300](#300)) ([86b43e4](86b43e4)) * **deps:** update prometheus-stack ([#190](#190)) ([f9a605a](f9a605a)) * **deps:** update uds-k3d to v0.6.0 ([#240](#240)) ([6a26523](6a26523)) * **deps:** update velero ([#260](#260)) ([f352008](f352008)) * **main:** release 0.18.0 ([#286](#286)) ([40e6b7b](40e6b7b)) * support headless keycloak admin user ([#307](#307)) ([a0e51b6](a0e51b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the cases when matchers are deleted because they're nearly identical but not actually identical.
Related Issue
Fixes #289
Additional Context
To help in bug fix and refactoring i merged #248 into this PR
Type of change
Checklist before merging