Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop path normalization to MERGE_SLASHES to allow apps to handle encoded slashes #330

Merged
merged 16 commits into from
Apr 11, 2024
Merged

fix: drop path normalization to MERGE_SLASHES to allow apps to handle encoded slashes #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
93e1e07
feat: add configurable encoded slash handling behavior to s
Racer159 Apr 5, 2024
645013a
Merge branch 'main' into 288-allow-configure-decode-slashes
Racer159 Apr 5, 2024
458ff1c
fix linting for generated files
Racer159 Apr 5, 2024
a867a59
add simple tests
Racer159 Apr 5, 2024
40955d4
fix lint
Racer159 Apr 5, 2024
107d39c
fix tests
Racer159 Apr 5, 2024
2f65727
fix tests
Racer159 Apr 5, 2024
63138de
fix lint
Racer159 Apr 5, 2024
2e979fc
Merge branch 'main' into 288-allow-configure-decode-slashes
Racer159 Apr 5, 2024
d752baf
fix accidental yolo
Racer159 Apr 5, 2024
5eeae9e
take the keyboard now
Racer159 Apr 5, 2024
bb5ce2f
bust down after feedback
Racer159 Apr 8, 2024
79eebe5
fix more
Racer159 Apr 8, 2024
4109e80
fix more
Racer159 Apr 8, 2024
487faae
Merge branch 'main' into 288-allow-configure-decode-slashes
mjnagel Apr 10, 2024
efaa7ce
make the logic betta
Racer159 Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/istio/values/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
meshConfig:
accessLogFile: /dev/stdout
pathNormalization:
normalization: DECODE_AND_MERGE_SLASHES
normalization: MERGE_SLASHES
defaultConfig:
holdApplicationUntilProxyStarts: true
gatewayTopology:
Expand Down
4 changes: 2 additions & 2 deletions src/pepr/operator/controllers/istio/injection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ export async function enableInjection(pkg: UDSPackage) {
const annotations = sourceNS.metadata?.annotations || {};
const pkgKey = `uds.dev/pkg-${pkg.metadata.name}`;

// Save the original value of the istio-injection label only if it's not already set
if (!annotations[injectionLabel]) {
// Mark the original namespace injection setting for if all packages are removed
if (!annotations[injectionAnnotation]) {
annotations[injectionAnnotation] = labels[injectionLabel] || "non-existent";
}

Expand Down