Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(loki): default query settings, config as secret #579

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

mjnagel
Copy link
Contributor

@mjnagel mjnagel commented Jul 16, 2024

Description

  • Updates to the same defaults for loki as are used on our staging test clusters (better experience querying logs)
  • Switches to a secret for the config rather than configmap (note that aws access keys end up in this configmap today if not using IRSA)
  • Cleans up some unnecessary values on tokengen (disabling sidecar, legacy BB values based on job termination issue)

Related Issue

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@mjnagel mjnagel requested a review from a team July 16, 2024 14:58
@mjnagel mjnagel self-assigned this Jul 16, 2024
@MxNxPx
Copy link
Contributor

MxNxPx commented Jul 16, 2024

Description

  • Updates to the same defaults for loki as are used on our staging test clusters (better experience querying logs)
  • Switches to a secret for the config rather than configmap (note that aws access keys end up in this configmap today if not using IRSA)
  • Cleans up some unnecessary values on tokengen (disabling sidecar, legacy BB values based on job termination issue)

Can confirm that these changes to the loki values fixed query issues we were experiencing.

            # Ensure we don't hit query limits
            - path: loki.limits_config.split_queries_by_interval
              value: "30m"
            - path: loki.query_scheduler.max_outstanding_requests_per_tenant
              value: 32000 # This is the new default in Loki 3.0
              ```

@mjnagel mjnagel merged commit 5fa889c into main Jul 16, 2024
13 checks passed
@mjnagel mjnagel deleted the loki-concurrent-ops branch July 16, 2024 17:57
mjnagel pushed a commit that referenced this pull request Jul 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.24.1](v0.24.0...v0.24.1)
(2024-07-22)


### Bug Fixes

* **ci:** snapshot release publish, passthrough test on upgrade
([#575](#575))
([d4afe00](d4afe00))
* **ci:** workflow permissions
([cacf1b5](cacf1b5))
* only allow istio gateways to set x509 client certificate header
([#572](#572))
([5c62279](5c62279))
* **sso:** delete orphaned SSO secrets
([#578](#578))
([5a6b9ef](5a6b9ef))
* unicorn flavor proxy image reference
([#590](#590))
([db081fa](db081fa))
* update monitor mutation to not overwrite explicitly defined scrape
class ([#582](#582))
([7e550d3](7e550d3))


### Miscellaneous

* **deps:** update grafana chart + sidecar image
([#567](#567))
([85b6de4](85b6de4))
* **deps:** update pepr to v0.32.7
([#556](#556))
([e594f13](e594f13))
* **deps:** update uds-identity-config to v0.5.1
([#591](#591))
([b9c5bd3](b9c5bd3))
* **deps:** update uds-k3d to v0.8.0
([#581](#581))
([fab8919](fab8919))
* **loki:** default query settings, config as secret
([#579](#579))
([5fa889c](5fa889c))
* **oscal:** begin integration of composed oscal with validations
([#496](#496))
([047fd30](047fd30))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants