Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account header username #19

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix: account header username #19

merged 1 commit into from
Mar 4, 2024

Conversation

UnicornChance
Copy link
Contributor

Description

Account Header was broken and now it isn't.

Before: The welcome-page-script would attempt to get the users givenName and familyName, which it would do successfully, and then it uses this reduce function to combine those two names into a single name, with the caveat that it has to have a specific format specified in the messages_en.properties file. That value was not set correctly for the reduce function to use the parameters.

Testing:

  1. Setup uds-core with keycloak/authservice
  2. create admin user
  3. go to sso.uds.dev and register a user
  4. in admin console verify that users email address ( should now be able to get to the users account )
  5. in the top right of the user account site, see the 'Full Name' beside the Sign Out button ( this should be the users full name )
  6. with that local cluster still running, go to this repo and branch and run uds run dev-theme to copy in the new theme for keycloak
  7. refreshing the users account should now show your users full name instead of the static text Full Name

...

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a while to get to this to test, LGTM!

@mjnagel mjnagel merged commit a05fe97 into main Mar 4, 2024
2 checks passed
@UnicornChance UnicornChance deleted the account-theme-fix branch March 11, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants