fix: expose environment variables #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mjnagel
reviewed
Jun 5, 2024
rjferguson21
approved these changes
Jun 5, 2024
rjferguson21
previously approved these changes
Jun 5, 2024
mjnagel
reviewed
Jun 5, 2024
mjnagel
approved these changes
Jun 5, 2024
UnicornChance
added a commit
to defenseunicorns/uds-core
that referenced
this pull request
Jun 6, 2024
## Description Updating default values for keycloak realm settings, identity-config realm.json files now use default values in the realm.json so there is no need for default values to live in uds-core. So removed those default values and instead added a comment block of values that could be used to override the default values. ## Related Issue [Relates to this uds-identity-config PR](defenseunicorns/uds-identity-config#95) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed
rjferguson21
pushed a commit
to defenseunicorns/uds-core
that referenced
this pull request
Jul 11, 2024
## Description Updating default values for keycloak realm settings, identity-config realm.json files now use default values in the realm.json so there is no need for default values to live in uds-core. So removed those default values and instead added a comment block of values that could be used to override the default values. ## Related Issue [Relates to this uds-identity-config PR](defenseunicorns/uds-identity-config#95) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've been asked by more than a couple people to expose some additional keycloak realm settings. This is that.
Added env vars for the following:
In updating/testing the changes to the password policy, there was a couple changes necessary for the realms to handle the use of the
digitsin thepasswordPolicy. While not strictly necessary a preemptive change to the cypress tests for user registration and login to update the passwords used was done as well.There is an additional PR in the uds-core repo for setting the default uds-core variables for these changes.
The uds-core PR will need to be merged and uds-core released before CI jobs here will pass because of the dependency on the default env variables set in uds-core.
Related Issue
Relates to #32
Type of change
Checklist before merging