Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add loki user and bucket #41

Merged
merged 3 commits into from
Feb 16, 2024
Merged

feat: add loki user and bucket #41

merged 3 commits into from
Feb 16, 2024

Conversation

rjferguson21
Copy link
Contributor

@rjferguson21 rjferguson21 commented Feb 14, 2024 •
edited
Loading

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@rjferguson21 rjferguson21 mentioned this pull request Feb 14, 2024
Merged
5 tasks
mjnagel
mjnagel reviewed Feb 15, 2024
View reviewed changes
values/minio-values.yaml Outdated Show resolved Hide resolved
mjnagel
mjnagel previously approved these changes Feb 15, 2024
View reviewed changes
mjnagel
mjnagel reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if we should also update docs here to indicate the default keys + bucket - https://github.com/defenseunicorns/uds-k3d/blob/main/docs/MINIO.md ?

@rjferguson21 rjferguson21 merged commit 509114d into main Feb 16, 2024
1 check passed
@rjferguson21 rjferguson21 deleted the logging-user branch February 16, 2024 17:32
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjnagel mjnagel mjnagel approved these changes

@zachariahmiller zachariahmiller zachariahmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjferguson21 @mjnagel @zachariahmiller